[SSSD] [PATCH] NSS: disable midpoint refresh for netgroups

Pavel Reichl preichl at redhat.com
Wed Oct 1 13:19:45 UTC 2014


Hello,

please see attached patch.

This patch is updated version of patch which was introduced in now stalled thread: NSS: disable midpoint refresh for netgroups if ptask refresh is enabled

I have picked some (from my POV) important comments from the previous thread and pasted them here.

Thanks!

On Mon, 2014-04-07 at 19:07 +0200, Jakub Hrozek wrote:

> What I meant is that this addition:
> +        if (req_type == SSS_DP_NETGR &&
> +            dctx->domain->refresh_expired_interval != 0) {
> +            ret = EOK;
>
> Makes sense as well to me, because this way neither midpoint refresh nor
> expired record request would be scheduled. What I'm not sure about is --
> would we expand this condition in the future when we add more background
> refresh types?

Jakub Hrozek wrote:

> >>> So how about checking that:
> >>>
> >>>    refresh_expired_interval < entry_cache_timeout
> >>
> >> Are you proposing to abort startup in this case? That sounds like a bit
> >> too heavy solution..
> >
> > No, I would rather log loudly about this problem and then I would set
> > refresh_expired_interval to entry_cache_timeout * 3/4 as is advised in
> > man pages. And again I would log this action loudly.
>
> That would work for me. I don't think we should over-engineer the
> solution, after all, the goal was to make it clear to the admin that
> they need to tune the config themselves..


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-NSS-disable-midpoint-refresh-for-netgroups.patch
Type: text/x-patch
Size: 4817 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141001/dd36c63b/attachment.bin>


More information about the sssd-devel mailing list