[SSSD] [PATCH] util: sss_get_domain_name regex mismatch not fatal

Jakub Hrozek jhrozek at redhat.com
Tue Nov 25 18:53:53 UTC 2014


On Tue, Nov 25, 2014 at 01:29:03PM +0100, Lukas Slebodnik wrote:
> On (24/11/14 20:50), Michal Židek wrote:
> >On 11/22/2014 05:48 PM, Jakub Hrozek wrote:
> >>On Fri, Nov 21, 2014 at 10:26:18PM +0100, Michal Židek wrote:
> >>>Hi,
> >>>
> >>>please see attached patch for ticket
> >>>https://fedorahosted.org/sssd/ticket/2487
> >>>
> >>>Probably in some part of the code we call the
> >>>function sss_get_domain_name with FQDN. We use
> >>>regular expression to check if it is the case and
> >>>if not (and regex is configured not to accept
> >>>non FQDN) than this function fails to construct the
> >>>requested name in the output.
> >>>
> >>>Since the sss_parse_name is here only used to detect
> >>>if the name contains domain portion, it is safe
> >>>to assume it does not contain it if regular
> >>>expression has failed to match anything.
> >>>
> >>>Michal
> >>
> 
> I tried to find another simple and nice solution
> but it's not possible at the moment.
> The situation might change if users are stored as fqdn in sysdb.

I think Michal should resume his work in this area once we're finished
with the 1.12 bugs. It really causes many hacks all around.



More information about the sssd-devel mailing list