[SSSD] [PATCH] be_ptask: Use first/enabled_delay with backoff feature

Pavel Březina pbrezina at redhat.com
Fri Nov 21 11:37:57 UTC 2014


On 11/20/2014 07:22 PM, Michal Židek wrote:
> Hi,
>
> it is probably not very intuitive to choose the
> 'period' parameter as the initial interval in
> the backoff feature (ptask). The first_delay and
> enabled_delay are more suitable for this.
>
> See the attached patch.
>
> Michal

I still don't think this is the best idea. Let's discuss it a little.

Can you remind me what is the purpose of the backoff feature? Why was it 
implemented? AFAIK it was to detect when we can get back online and the 
randomization was added to spread the load on a server.

I don't like the fact that in the current state the delay parameter is 
ignored if the backoff is set. And therefore all first delay, enabled 
delay and period (with your new patch) is ignored.

If I understand the purpose of this backoff feature correctly, you want 
to increase the period after each execution. But in my opinion you 
should still obey the first delay and enabled delay and use the *exact* 
times (even without the random offset IMHO).

Attached is an *untested* patch to illustrate what I have in mind.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-be_ptask-let-backoff-affect-only-period.patch
Type: text/x-patch
Size: 8254 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20141121/c6cd95c1/attachment.bin>


More information about the sssd-devel mailing list