[SSSD] [PATCH] nss: return ldap_user_extra_attrs attributes in origbyname request

Jakub Hrozek jhrozek at redhat.com
Tue Nov 4 11:17:43 UTC 2014


On Wed, Oct 29, 2014 at 01:01:43PM +0100, Sumit Bose wrote:
> I agree, I allowed user_attributes for the nss responder as well with a
> fallback to the InfoPipe value so the admin gets it for free if InfoPipe
> is already configured but does not have to configure InfoPipe if not
> needed. See man page change for details.
> 
> Thank you for the review, new version attached.
> 
> bye,
> Sumit

I'm sorry about the delay in review.

This version looks almost good, but I have one more request -- can we
move ifp_parse_attr_list_ex into responder_common.c and drop the ifp
prefix?

What that would prevent in particular is:
> diff --git a/src/responder/nss/nsssrv.c b/src/responder/nss/nsssrv.c
> index 1bbeaa1..601ffc2 100644
> --- a/src/responder/nss/nsssrv.c
> +++ b/src/responder/nss/nsssrv.c
> @@ -48,6 +48,7 @@
>  #include "monitor/monitor_interfaces.h"
>  #include "sbus/sbus_client.h"
>  #include "util/util_sss_idmap.h"
> +#include "responder/ifp/ifp_private.h"
>  

I know we're currently only using a single function, but it's not very
nice to use a private interface of another responder.

I'm fine with the rest of the code.



More information about the sssd-devel mailing list