[SSSD] [PATCH] AD: Add initial gpo-smb implementation.

Lukas Slebodnik lslebodn at redhat.com
Fri May 30 16:15:29 UTC 2014


On (29/05/14 09:06), Yassir Elley wrote:
>----- Original Message -----
>> On Thu, May 29, 2014 at 04:09:21AM -0400, Yassir Elley wrote:
>> > Also note that some (but not all) of the changes that were pushed to master
>> > as part of my patch titled "add libsmbclient to makefiles" seem to have
>> > been
>> > deleted by subsequent pushes to master. As such, this patch reintroduces
>> > those changes (which only affect configure.ac and libsmbclient.m4).
>> 
>> That would be worrisome, what changes in particular? I'm not aware of
>> pushing anything else than acked patches from the list..
>> 
>> Are you talking about the autoconf refactor Lukas did? IIRC that one
>> only merged some code duplicates into a single file..
>> _______________________________________________
>> sssd-devel mailing list
>> sssd-devel at lists.fedorahosted.org
>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>> 
>
>Hi Jakub,
>
>You are right. I overlooked the fact that the autoconf refactor had moved things around. My mistake.
>
>Revised patch attached.
>
>Regards,
>Yassir.

>From abc4ac3e664ccbeeb58d131dc6c37cc314f5ba3d Mon Sep 17 00:00:00 2001
>From: Yassir Elley <yelley at redhat.com>
>Date: Wed, 21 May 2014 15:11:36 -0400
>Subject: [PATCH] AD-GPO: Add initial gpo-smb implementation
>
>---
> src/providers/ad/ad_gpo.c | 680 +++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 676 insertions(+), 4 deletions(-)
>
>diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c
>index 168ed2d7e8657799a7c773ec8b24897cdd303ec4..519c0dbec4d85e7f6e41db672ae0f2c2f720d81b 100644
>--- a/src/providers/ad/ad_gpo.c
>+++ b/src/providers/ad/ad_gpo.c
>@@ -31,6 +31,9 @@
>  */
> 
> #include <security/pam_modules.h>
>+#include <libsmbclient.h>
>+#include <ini_configobj.h>
>+#include <ini_config.h>
            ^^^^^^^^^^^^
This is the old ini_config interface. You can remove this line.

> #include "util/util.h"
> #include "util/strtonum.h"
> #include "providers/data_provider.h"

// snip

>+    int ret;
>+    char **allow_sids = NULL; char **deny_sids = NULL;
>+    int allow_size = 0; int deny_size = 0;
>+
>+    ret = ini_config_create(&ini_config);
>+    if (ret) goto done;
>+    ret = ini_config_file_from_mem(data_buf, data_len, &file_ctx);
            ^^^^^^^^^^^^^^^^^^^^^^^^
This function is available in libini_config-1.1
Please, update buildrequires in spec file.

diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
index b5e7903..10704ae 100644
--- a/contrib/sssd.spec.in
+++ b/contrib/sssd.spec.in
@@ -97,7 +97,7 @@ BuildRequires: libtdb-devel
 BuildRequires: libldb-devel
 BuildRequires: libdhash-devel >= 0.4.2
 BuildRequires: libcollection-devel
-BuildRequires: libini_config-devel
+BuildRequires: libini_config-devel >= 1.1
 BuildRequires: dbus-devel
 BuildRequires: dbus-libs
 %if 0%{?rhel5_minor} >= 7

LS



More information about the sssd-devel mailing list