[SSSD] NSS: Add config option to expand homedir template format

Stephen Gallagher sgallagh at redhat.com
Fri May 30 13:34:00 UTC 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/28/2014 12:22 PM, Lukas Slebodnik wrote:
> On (27/05/14 16:32), Jakub Hrozek wrote:
>> On Tue, May 27, 2014 at 01:03:42PM +0200, Pavel Reichl wrote:
>>> On Tue, 2014-05-27 at 11:24 +0200, Lukas Slebodnik wrote:
>>>> O
>>>>> The fact of passing pointer to the same area in memory to 2
>>>>> separate arguments of sss_parse_name() is what I called
>>>>> potential source of bugs. You said "It seems strange to me"
>>>>> so I hope you know what I mean.
>>>> It is strange, but it isn't wrong. * orig_name refers to old
>>>> string * homedir_ctx->username will refer to new string. I
>>>> need to use old string in debug message if function fails.
>>> I missed that.
>>> 
>>> I did some testing and all seems to be working, so ACK to all
>>> patches.
>>> 
>> 
>> In the third patch, you need to add the file 
>> src/man/include/override_homedir.xml into src/man/po/po4a.cfg to
>> make sure
> You ment homedir_substring.xml
> 
>> it's processed for translations.
>> 
> Added
> 
>> Can you ask some native English speaker to check the contents of
>> the text added?
>> 
>> As a side note, it would be nice to treat any refactoring as an 
>> opportunity for adding more unit tests. Neither
>> expand_homedir_template nor sss_parse_name_const have any tests.
> The test for expand_homedir_template is in separate commit, because
> patches with refactoring are complicated enough.
> 
> LS


Grammar cleanup on the manpage:

The value of this option will be used in the expansion of the
<emphasis>override_homedir</emphasis> option if the template contains
the format string <emphasis>%H</emphasis>. An LDAP directory entry can
directly contain this template so that this option can be used to
expand the home directory path for each client machine (or operating
system). It can be set per-domain or globally in the [nss] section. A
value specified in a domain section will override one set in the [nss]
section.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlOIiMgACgkQeiVVYja6o6OSpACfYeF7bamazJJP0bXfBhSuN7dy
OgsAoI5NqsmjFcFHdmMUsj9J+0BnMfAm
=VBZ6
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list