[SSSD] [PATCH] BUILD: Disable dbus tests when running distcheck

Lukas Slebodnik lslebodn at redhat.com
Fri May 30 11:39:08 UTC 2014


On (30/05/14 13:35), Jakub Hrozek wrote:
>On Fri, May 30, 2014 at 12:58:20PM +0200, Lukas Slebodnik wrote:
>> >+AC_ARG_ENABLE([dbus-tests],
>> >+              [AS_HELP_STRING([--enable-dbus-tests],
>> >+                              [enable running tests using a dbus server
>> >                                                instance [default=enabled]])],
>>                                                            ^^^^^^^^^^^^^^^
>>                                                            default is yes
>> The help string will be consistent with other options.
>>   --enable-shared[=PKGS]  build shared libraries [default=yes]
>>   --enable-fast-install[=PKGS]
>>                           optimize for fast installation [default=yes]
>> 
>> >+              [build_dbus_tests=$enableval],
>> >+              [build_dbus_tests=yes])
>> >+AM_CONDITIONAL([BUILD_DBUS_TESTS], [test x$build_dbus_tests = xyes])
>> >-- 
>> >1.9.0
>> >
>> 
>> Otherwise, patch works fine.
>
>OK, the yes/no seemed a bit odd to me if the option is
>--enable/--disable, but I don't mind too much either.

>From 03c1f0bc50dcb88c74154a87f736d68adf006721 Mon Sep 17 00:00:00 2001
>From: Jakub Hrozek <jhrozek at redhat.com>
>Date: Fri, 30 May 2014 10:33:43 +0200
>Subject: [PATCH] BUILD: Disable dbus tests when running distcheck
>
>https://fedorahosted.org/sssd/ticket/2291
>
>The dbus tests that mock an sbus server were failing when make distcheck
>was ran by a user logged in through the SSSD.
>
>The reason was that the libtool wrapper around the test library alters
>the LD_LIBRARY_PATH and as a consequence, the standard getpwuid_r() calls
>the dbus server performs would load the in-tree NSS library and not the
>system one.  The-in tree library would then attempt to talk to an in-tree
>NSS socket, fail, which would fail the getpwuid_r call with an error such as:
>
>"""
>    Could not get password database information for UID of current process:
>    User "???" unknown or no memory to allocate password entry
>"""
>
>This patch adds a new configure-time option called --enable-dbus-tests
>that is enabled by default and disabled during distcheck. When the
>option is disabled, the tests that require a mocked dbus server are not
>compiled at all.
>---
Thanks

ACK

LS



More information about the sssd-devel mailing list