[SSSD] IFP: Implement methods to get and list domain objects

Lukas Slebodnik lslebodn at redhat.com
Wed May 28 12:15:06 UTC 2014


On (28/05/14 11:05), Pavel Březina wrote:
>On 05/28/2014 10:48 AM, Jakub Hrozek wrote:
>>On Tue, May 27, 2014 at 10:28:42PM +0200, Pavel Březina wrote:
>>>Hi,
>>>I'm starting a new thread branch, since the review mails got kind of
>>>separated and it starts to be confusing.
>>>
>>>I'm sending new patch set including also Jakub's tests, all issues
>>>should be fixed.
>>>
>>>Ack to all Jakub's patches.
>>
>>Squash in the following patch to the ifp_domains code and I'll ack :-)
>
>Thanks. New patches are attached.
>

There is a warning:
src/responder/ifp/ifp_components.c:443:61: error: format string is not a string literal
      (potentially insecure) [-Werror,-Wformat-security]
        error = sbus_error_new(dbus_req, DBUS_ERROR_FAILED, strerror(EINVAL));
                                                            ^~~~~~~~~~~~~~~~
1 error generated.

And warnings from static analysers
Error: CLANG_WARNING: [#def2]
sssd-1.11.90/src/responder/ifp/ifp_components.c:497:9: warning: Value stored to 'error' is never read
#        error = sbus_error_new(dbus_req, DBUS_ERROR_NOT_SUPPORTED, NULL);
#        ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: CLANG_WARNING: [#def4]
sssd-1.11.90/src/responder/ifp/ifp_components.c:566:9: warning: Value stored to 'error' is never read
#        error = sbus_error_new(dbus_req, DBUS_ERROR_NOT_SUPPORTED, NULL);
#        ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

LS



More information about the sssd-devel mailing list