[SSSD] IFP: Implement methods to get and list domain objects

Pavel Březina pbrezina at redhat.com
Mon May 26 20:36:35 UTC 2014


On 05/26/2014 07:05 PM, Jakub Hrozek wrote:
> On Thu, May 22, 2014 at 07:57:28PM +0200, Pavel Březina wrote:
>> On 05/21/2014 11:03 PM, Jakub Hrozek wrote:
>>> Hi,
>>>
>>> the attaches two patches implement DBus methods to retrieve SSSD domains
>>> using the system bus as well as two example getters that leverage the
>>> infrastructure to Get and GetAll the object properties.
>>>
>>> Pavel, I know you have a large patchset in a private tree that
>>> implements the other getters and moves the domain methods into a
>>> separate file. I'm fine with merging your and mine patches, I just
>>> wanted to get the ball rolling on the list. Feel free to reply with your
>>> patchset.
>>
>> Hi,
>> see the attachment.
>>
>> I squash all my patches to these five - mainly discarded the moving
>> the code around.
>>
>> I kept you as the author for the methods as I made only very minor
>> changes there. However, I took the ownership for the properties
>> since there only very little of your original code remains there - I
>> hope you don't mind.
>>
>> The next three patches implements the SSSD components interface
>> required for the OpenLMI provider. I'm sending it to this thread
>> since it depends on the domain patches anyway - there is enough
>> dependency fuzz already.
>>
>
>>  From 0f1e1adba39f203ad6405531a21d28d5c9bfa9ac Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina at redhat.com>
>> Date: Mon, 5 May 2014 13:28:34 +0200
>> Subject: [PATCH 3/5] confdb: add confdb_list_all_domain_names()
>
> ACK.
>
> See attached unit test I used for testing.

Hi,
the tests looks good, however there are three tests in one test. It 
should be split.




More information about the sssd-devel mailing list