[SSSD] [PATCH] contrib: add BuildRequires libsmbclient-devel to spec file

Lukas Slebodnik lslebodn at redhat.com
Fri May 23 15:03:35 UTC 2014


On (23/05/14 16:59), Jakub Hrozek wrote:
>On Fri, May 23, 2014 at 03:57:06PM +0200, Lukas Slebodnik wrote:
>> On (23/05/14 13:28), Sumit Bose wrote:
>> >Hi,
>> >
>> >I just realized that libsmbclient it not covered by the general
>> >samba-devel package. The patch add the needed BuildRequires to the spec
>> >file.
>> >
>> >bye,
>> >Sumit
>> 
>> >From 6508989d0304dbd8c8c463e7adb955806582f0df Mon Sep 17 00:00:00 2001
>> >From: Sumit Bose <sbose at redhat.com>
>> >Date: Fri, 23 May 2014 13:25:32 +0200
>> >Subject: [PATCH] contrib: add BuildRequires libsmbclient-devel to spec file
>> >
>> >---
>> > contrib/sssd.spec.in | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> >diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
>> >index b60ce8a..d4114cd 100644
>> >--- a/contrib/sssd.spec.in
>> >+++ b/contrib/sssd.spec.in
>> >@@ -143,6 +143,7 @@ BuildRequires: cifs-utils-devel
>> > %if !0%{?is_rhel5}
>> > BuildRequires: samba4-devel
>> > %endif
>> >+BuildRequires: libsmbclient-devel
>> I am curious which file use functions from library libsmbclient?
>> 
>> All functions from this library has prefix smbc_
>> 
>> sh-4.2$ nm --dynamic --defined-only /usr/lib64/libsmbclient.so.0 | grep -v smbc_
>> 0000000000000000 A SMBCLIENT_0.1.0
>> 0000000000000000 A SMBCLIENT_0.2.0
>> 0000000000000000 A SMBCLIENT_0.2.1
>> 
>> And I could not find any function in current master
>>     b1c4a998f8e217b4ba4cd632f5069d479211c22d
>> 
>> [user at host][~/sssd]$ git grep smbc_
>> [user at host][~/sssd]$ echo $?
>> 1
>> 
>> Is this preparation for further patches?
>
>Yes. This dependency was introduced in commit:
>    commit b1c4a998f8e217b4ba4cd632f5069d479211c22d
>    Author: Yassir Elley <yelley at redhat.com>
>    Date:   Wed May 21 19:58:52 2014 -0400
>
>        AD-GPO: add libsmbclient to makefiles
>
>        Reviewed-by: Sumit Bose <sbose at redhat.com>
>
>
>In the e-mail to the list, Yassir wrote:
>"""
>The attached patch adds libsmbclient to the makefiles, in preparation
>for adding libsmbclient calls to the gpo-smb code
>"""
I was aware of this patch, but I didn't notice that is
"in preparation for"

We should push Sumit's patch, because rpms cannot be built from current master.

LS



More information about the sssd-devel mailing list