[SSSD] [PATCH 1/1] tests: Don't assume absolute test dir in test_io.c

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Fri May 23 10:11:44 UTC 2014


On 05/23/2014 12:39 PM, Nikolai Kondrashov wrote:
> On 05/21/2014 01:20 PM, Nikolai Kondrashov wrote:
>> On 05/19/2014 08:34 PM, Nikolai Kondrashov wrote:
>>> Yes, I managed not to notice this before, behind other errors, but I get these
>>> too. It seems it is reall a Valgrind issue. I.e. it doesn't seem to make sense
>>> to apply "--error-exitcode" to child processes.
>>>
>>> However, it seems that the exit status of the process in question is hardcoded
>>> to zero. So, can we perhaps work this around for now by changing the assertion
>>> to the following?
>>>
>>>      verify_eq (WIFSIGNALED(child_status), 0);
>>>
>>> If yes, I'll submit a patch.
>>
>> Scratch that. The "--error-exitcode" option is useless with child tracking,
>> anyway. Any errors in children will not affect exit code of the parent
>> Valgrind. I guess I'll have to do XML Valgrind output and analyze that.
>> Sigh...
>
> Nope. Valgrind's XML output is useless for forked programs. XML gets all
> jumbled up. Valgrind outputs to separate files only for children which exec'd.

It appears this problem has been known for a long time and, for example,
Google maintains their own version of Valgrind, which has it fixed:
http://code.google.com/p/valgrind-variant/

However, I don't think we're in the business of tracking that fork.
This is just an illustration.

Nick



More information about the sssd-devel mailing list