[SSSD] [PATCH] Implement org.freedesktop.DBus.Properties.GetAll for primitive types

Lukas Slebodnik lslebodn at redhat.com
Fri May 23 07:36:05 UTC 2014


On (23/05/14 08:31), Lukas Slebodnik wrote:
>On (21/05/14 22:53), Jakub Hrozek wrote:
>>Hi,
>>
>>the attached patches implement the
>>org.freedesktop.DBus.Properties.GetAll method for retrieving primitive
>>types and their arrays.
>>
>>The patchset build on the previous set (currently still on review) that
>>implements the .Get method. The GetAll handler simply walks through the
>>existing getters and retrieves the results, storing them in a single
>>variant.
>>
>>The patches include a unit test that tests all currently supported
>>combinations of primitive types and array of primitive types.
>
>>From fc4b278c0914b2c7001393e471f4f6f0b532ba54 Mon Sep 17 00:00:00 2001
>>From: Jakub Hrozek <jhrozek at redhat.com>
>>Date: Wed, 21 May 2014 16:48:45 +0200
>>Subject: [PATCH 1/5] SBUS: Add utility function sbus_add_variant_to_dict
>>
>>---
>> src/sbus/sssd_dbus.h            |   5 ++
>> src/sbus/sssd_dbus_properties.c | 116 ++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 121 insertions(+)
>>
>src/sbus/sssd_dbus_properties.c:287:41: error: no member named 'invoker_get_all' in
>      'struct sbus_interface_meta'
>                                  meta->invoker_get_all);
>                                  ~~~~  ^
>It is introduced in 4th aptch
>"SBUS: Implement org.freedesktop.DBus.Properties.GetAll for primitive types"
>
>>From 32d84445012991dba38ee5b60f5614aca70b889d Mon Sep 17 00:00:00 2001
>>From: Jakub Hrozek <jhrozek at redhat.com>
>>Date: Wed, 21 May 2014 20:10:23 +0200
>>Subject: [PATCH 5/5] SBUS: Add org.freedesktop.DBus.Properties.GetAll to
>> Introspection
>
>FAIL: sbus_tests
>
>sbys_tests.log file is attached.
>
>LS

Ii is probably unrelated to failed test, but there is another gcc warning
introduced in 4th patch.

src/tests/sbus_codegen_tests.c: In function ‘check_arr_prop’:
sssd/src/tests/sbus_codegen_tests.c:1225:30: error: ‘strings’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
             ck_assert_str_eq(strings[1], pilot_path_array[1]);
                              ^
cc1: all warnings being treated as errors

LS



More information about the sssd-devel mailing list