[SSSD] [PATCH] Implement org.freedesktop.DBus.Properties.GetAll for primitive types

Jakub Hrozek jhrozek at redhat.com
Thu May 22 18:37:23 UTC 2014


On Thu, May 22, 2014 at 07:39:06PM +0200, Pavel Březina wrote:
> On 05/21/2014 10:53 PM, Jakub Hrozek wrote:
> >Hi,
> >
> >the attached patches implement the
> >org.freedesktop.DBus.Properties.GetAll method for retrieving primitive
> >types and their arrays.
> >
> >The patchset build on the previous set (currently still on review) that
> >implements the .Get method. The GetAll handler simply walks through the
> >existing getters and retrieves the results, storing them in a single
> >variant.
> >
> >The patches include a unit test that tests all currently supported
> >combinations of primitive types and array of primitive types.
> 
> Ack.
> 
> Thanks for squashing my patches in.

Would you prefer to have any of them separately to preserve attribution?

I wasn't sure if the review and the patches themselves wouldn't look out
of context, but I'm all for giving credit.

The only one I split was the large sbus helper for arrays.



More information about the sssd-devel mailing list