[SSSD] [PATCH] Implement type-safe getters for primitive types and their arrays
Jakub Hrozek
jhrozek at redhat.com
Thu May 15 22:44:25 UTC 2014
On Tue, May 13, 2014 at 06:04:06PM +0200, Lukas Slebodnik wrote:
> >+ dbret = dbus_message_iter_close_container(&iter, &valiter);
> >+ if (!dbret) {
> >+ sbus_request_finish(dbus_req, NULL);
> >+ ret = EINVAL;
> >+ goto done;
> >+ }
> // dbret will be 0 after this line
I've removed the above and only let the if-else below. Thanks for
catching this.
> >+
> >+ if (dbret) {
> >+ ret = sbus_request_finish(dbus_req, reply);
> >+ } else {
> >+ DEBUG(SSSDBG_CRIT_FAILURE, "Couldn't build DBus message\n");
> >+ sbus_request_finish(dbus_req, NULL);
> >+ ret = EINVAL;
> // this branch is dead code
> >+ }
> >+
> >+done:
> >+ dbus_message_unref(reply);
> >+ return ret;
> >+}
> >+
More information about the sssd-devel
mailing list