[SSSD] [PATCH] SYSV: Do not call functions success and fail itself

Lukas Slebodnik lslebodn at redhat.com
Thu Mar 20 15:43:44 UTC 2014


ehlo,

Bash function daemon will call success or fail. It is useless to call them
one more time. It may cause strange behaviour with some configurations of
terminal.

 # service sssd restart
 Stopping sssd: [  OK  ]
 [  OK  ] sssd: [  OK  ]

Resolves:
https://fedorahosted.org/sssd/ticket/2280

sh-4.1# grep -Rn daemon /etc/init.d/ | grep failure
/etc/init.d/sssd:46:    daemon $SSSD -f -D && success || failure
sh-4.1# grep -Rn daemon /etc/init.d/ | grep success
/etc/init.d/sssd:46:    daemon $SSSD -f -D && success || failure

sh-4.1# ls -1 /etc/init.d/ | wc -l
57

simple patch is attached.

LS
-------------- next part --------------
>From fcf37d040cef6cad52c7601baade53f6a8fe6641 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Thu, 20 Mar 2014 16:23:34 +0100
Subject: [PATCH] SYSV: Do not call functions success and fail itself

Bash function daemon will call success or fail. It is useless to call them
one more time. It may cause strange behaviour with some configurations of
terminal.

 # service sssd restart
 Stopping sssd: [  OK  ]
 [  OK  ] sssd: [  OK  ]

Resolves:
https://fedorahosted.org/sssd/ticket/2280
---
 src/sysv/sssd.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sysv/sssd.in b/src/sysv/sssd.in
index 6155df97cf135968052ca9244f15562fb9b2853d..5109148acc444970d4553b1276fb2625782abb57 100644
--- a/src/sysv/sssd.in
+++ b/src/sysv/sssd.in
@@ -43,7 +43,7 @@ PID_FILE=@localstatedir@/run/sssd.pid
 start() {
     [ -x $SSSD ] || exit 5
     echo -n $"Starting $prog: "
-    daemon $SSSD -f -D && success || failure
+    daemon $SSSD -f -D
     RETVAL=$?
     echo
     [ "$RETVAL" = 0 ] && touch $LOCK_FILE
-- 
1.8.5.3



More information about the sssd-devel mailing list