[SSSD] [Patch] Cmocka unit test for negcache.c module

Michal Židek mzidek at redhat.com
Thu Mar 6 16:25:47 UTC 2014


On 03/06/2014 01:24 PM, Lukas Slebodnik wrote:
> On (06/03/14 09:50), Jakub Hrozek wrote:
>> On Thu, Mar 06, 2014 at 09:26:40AM +0100, Lukas Slebodnik wrote:
>>> On (05/03/14 22:33), Jakub Hrozek wrote:
>>>> On Wed, Mar 05, 2014 at 04:24:19PM +0545, Pallavi Jha wrote:
>>>>> Hi,
>>>>>
>>>>>
>>>>> Few changes mentioned in earlier mail are added and the required comment is
>>>>> also added for mock_rctx(), as was discussed with Jakub. Kindly review the
>>>>> patch.
>>>>>
>>>>>
>>>>> Thanks!
>>>>> Pallavi
>>>>
>>>> The patch now looks good and the test passes, so I'll ACK it.
>>>>
>>>> Please note that when I applied the patch, the test failed, complaining
>>>> about a failure on line 603, which would mean create_dom_test_ctx()
>>>> failed. But I haven't been able to reproduce the error again, subsequent
>>>> runs went OK for me. If someone else sees the failure, please holler.
>>>
>>> I don't know why, but I am able to reproduce it :-(
>>>
>>> (Thu Mar  6 09:23:04:051345 2014) [sssd] [ldb] (0x0020): Unable to open tdb 'tests_nss/test_nss_conf.ldb'
>>> (Thu Mar  6 09:23:04:051412 2014) [sssd] [ldb] (0x0020): Failed to connect to 'tests_nss/test_nss_conf.ldb' with backend 'tdb': Unable to open tdb 'tests_nss/test_nss_conf.ldb'
>>> (Thu Mar  6 09:23:04:051425 2014) [sssd] [confdb_init] (0x0010): Unable to open config database [tests_nss/test_nss_conf.ldb]
>>> (Thu Mar  6 09:23:04:051446 2014) [sssd] [create_dom_test_ctx] (0x0020): confdb_init failed: 5
>>> tc
>>> ../sssd/src/tests/cmocka/test_negcache.c:603: error: Failure!
>>> [  FAILED  ] test_sss_ncache_prepopulate
>>>
>>>
>>>
>>> BTW The test will not fail if I run "make rpms"
>>>
>>> LS
>>
>> I was actually hoping you could reproduce this, you have a way with
>> strange bugs :-)
>>
>> But on my machine, all tests still pass. Provided you can reproduce
>> this, can you also send a patch?
>
> done.
>
> LS
>

ACK.

There are no more TESTS_PATH collisions in the code now.

Michal




More information about the sssd-devel mailing list