[SSSD] [PATCH] sudo: return after tevent_req_error

Jakub Hrozek jhrozek at redhat.com
Fri Jun 27 08:30:35 UTC 2014


On Thu, Jun 26, 2014 at 06:35:33PM +0200, Sumit Bose wrote:
> On Thu, Jun 26, 2014 at 05:56:06PM +0200, Pavel Reichl wrote:
> > Sorry, I just noticed missing '\n' in context.
> > 
> > On Thu, 2014-06-26 at 17:37 +0200, Sumit Bose wrote:
> > > On Thu, Jun 26, 2014 at 05:33:39PM +0200, Pavel Reichl wrote:
> > > > Hello, 
> > > > 
> > > > please see attached patch.
> > > 
> > > good catch, obvious ACK.
> > > 
> > > bye,
> > > Sumit
> > > 
> > > > 
> > > > Thanks,
> > > > PR
> > > 
> > > > From 7249e59cd00050a81780d99e7bdfcdeb0a01a144 Mon Sep 17 00:00:00 2001
> > > > From: Pavel Reichl <preichl at redhat.com>
> > > > Date: Thu, 26 Jun 2014 16:21:16 +0100
> > > > Subject: [PATCH] sudo: return after tevent_req_error
> > > > 
> > > > Don't call tevent_req_done after tevent_req_error (for the same request).
> > > > ---
> > > >  src/responder/sudo/sudosrv_query.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/src/responder/sudo/sudosrv_query.c b/src/responder/sudo/sudosrv_query.c
> > > > index 632afa712c9c08af7ed253f77705e35f49b6b039..4d19514cd63f432d7cee2bbfbece237fb56c5dec 100644
> > > > --- a/src/responder/sudo/sudosrv_query.c
> > > > +++ b/src/responder/sudo/sudosrv_query.c
> > > > @@ -364,6 +364,7 @@ static void sudosrv_parse_query_done(struct tevent_req *subreq)
> > > >      talloc_free(subreq);
> > > >      if (ret != EOK) {
> > > >          tevent_req_error(req, ret);
> > > > +        return;
> > > >      }
> > > >  
> > > >      tevent_req_done(req);
> > > > -- 
> > > > 1.8.4.2
> > > > 
> > > 
> > > > _______________________________________________
> > > > sssd-devel mailing list
> > > > sssd-devel at lists.fedorahosted.org
> > > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> > > 
> > > _______________________________________________
> > > sssd-devel mailing list
> > > sssd-devel at lists.fedorahosted.org
> > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> > 
> 
> This looks like an obvious ACK to me as well.
> 
> bye,
> Sumit

master:
0d47aef7577f8cf651255cf59df87b3847dbe1ad



More information about the sssd-devel mailing list