[SSSD] [PATCH] build: Allow augmenting TESTS_ENVIRONMENT

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Mon Jun 23 15:13:57 UTC 2014


On 06/23/2014 05:45 PM, Jakub Hrozek wrote:
> On Thu, Jun 19, 2014 at 08:24:30PM +0300, Nikolai Kondrashov wrote:
>> On 06/19/2014 08:23 PM, Nikolai Kondrashov wrote:
>>> This patch enables executing "make check" with tests running under Valgrind on
>>> RHEL6, where Automake doesn't support LOG_COMPILER.
>>
>> And now the patch itself :)
>
>>  From e33c7f5b5dc58f590ac8578117a5937d03632c31 Mon Sep 17 00:00:00 2001
>> From: Nikolai Kondrashov <Nikolai.Kondrashov at redhat.com>
>> Date: Thu, 19 Jun 2014 18:55:34 +0300
>> Subject: [PATCH 1/1] build: Allow augmenting TESTS_ENVIRONMENT
>>
>> Add substitution of a special variable "AUX_TESTS_ENVIRONMENT" to the
>> "TESTS_ENVIRONMENT" value, allowing its augmentation from the make
>> command line. This enables wrapping test commands with older versions of
>> Automake, where LOG_COMPILER support is missing.
>>
>> This enables executing "make check" target with Valgrind on RHEL6, like
>> this:
>>
>>      make check AUX_TESTS_ENVIRONMENT="libtool --mode=execute valgrind"
>
> Tested using this ^ command on RHEL-6 and Fedora-20. Both went fine.

Thank you.

I wouldn't recommend using this with newer Automake (e.g. on Fedora), as it
would run the shell executing the test driver under Valgrind, and wouldn't
actually check the tests themselves, as "--trace-children" is not used.

Use LOG_COMPILER and LOG_FLAGS with recent Automake.

CI would take care of this difference.

Nick



More information about the sssd-devel mailing list