[SSSD] [PATCH] LDAP: Don't use macro _XOPEN_SOURCE for extra features

Lukas Slebodnik lslebodn at redhat.com
Wed Jun 18 11:29:33 UTC 2014


On (26/05/14 16:57), Jakub Hrozek wrote:
>On Mon, May 26, 2014 at 04:52:28PM +0200, Jakub Hrozek wrote:
>> On Sat, May 24, 2014 at 07:38:17PM +0200, Lukas Slebodnik wrote:
>> > On (24/05/14 19:10), Lukas Slebodnik wrote:
>> > >ehlo,
>> > >
>> > >We defined macro _XOPEN_SOURCE before time.h, because we need function strptime
>> > >The problem is with undef after including header time.h
>> > >The macro _XOPEN_SOURCE can be defined on some platforms
>> > >and undef can cause problems.
>> > >
>> > >We detect all necessary feature macros in configure script
>> > >using AC_USE_SYSTEM_EXTENSIONS or AC_GNU_SOURCE.
>> > >It is better to include header file config.h
>> > >instead of defining macro _XOPEN_SOURCE
>> > >
>> > >LS
>> > 
>> > attached patch with small change.
>> > 
>> > LS
>> 
>> Similar to other patches in the mini-thread, I only tested by building
>> on F-20 and RHEL-6. The build went fine, no new errors or warnings.
>> 
>> ACK
>
>Pushed to master: 80c092f94a7ac24ea00e560201e37ae27cfbf665
Could you push patch also to 1.11 branch?

LS



More information about the sssd-devel mailing list