[SSSD] [PATCH] SPEC: Drop rhel5 conditions in spec file.

Pavel Březina pbrezina at redhat.com
Thu Jun 12 12:03:31 UTC 2014


On 06/06/2014 02:29 PM, Lukas Slebodnik wrote:
> On (23/05/14 17:50), Lukas Slebodnik wrote:
>> On (23/05/14 17:47), Lukas Slebodnik wrote:
>>> ehlo,
>>>
>>> In theory, it could be possible to build current master without samba
>>> on rhel5, but the spec file would be very complicated.
>>> It is better to simplify spec file.
>>>
>>> Patch is attached.
>>> 1 file changed, 43 deletions(-) :-)
>>>
>>> LS
>> The patch lost somewhere.
>>
>> One more time
>>
>> LS
>
> I found out there is already similar ticket.
> Attached patch also get rid of Fedora 17 and older conditionals
>      1 file changed, 6 insertions(+), 76 deletions(-) :-)
>
> LS
>
> PS: With recent patches[1][2][3][4], it is possible to build sssd on rhel5.
> (without samba and without python bindings). The spec file would be very
> complicated. I have a modified spec in my private branch. If we want we can
> have spec file for epel5 in contrib directory.
>
> [1] b3007e32fa5d6b722f3aaaf9fe7593103cb443c3
> [2] 1ecb16023779f912ba1c4e9e418acb59296ce8bc
> [3] 18647db9e275e7aa3e002551237abae756a2afb9
> [4] a2e417f38c57ed87c956ddcecf4dafca93842b65

What a nice spec file it is! :)

I have just one question, this diff actually seems to add a condition 
intead of remove it:
  BuildRequires: glib2-devel
  BuildRequires: selinux-policy-targeted
-%if (0%{?fedora} >= 18)
+%if 0%{?fedora}
  BuildRequires: libcmocka-devel
+%endif
+%if (0%{?fedora} || 0%{?rhel} >= 7)
  BuildRequires: libnl3-devel
  %else
  BuildRequires: libnl-devel
@@ -139,10 +115,7 @@ BuildRequires: systemd-devel
  BuildRequires: cifs-utils-devel
  %endif

Can you move it to a separate commit?




More information about the sssd-devel mailing list