[SSSD] [PATCHES] Build fixes and improvements

Jakub Hrozek jhrozek at redhat.com
Tue Jul 29 14:42:35 UTC 2014


On Mon, Jul 28, 2014 at 08:45:41PM +0300, Nikolai Kondrashov wrote:
> Hi everyone,
> 
> Here is a bunch of various build fixes and improvements mainly concerned with
> libini_config detection.
> 
> Nick

> From d1bd23332bb504b3780fb4ba6ad1a92e4d2ab3f5 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov <Nikolai.Kondrashov at redhat.com>
> Date: Mon, 28 Jul 2014 17:02:10 +0300
> Subject: [PATCH 1/6] build: Remove substitution of *_OBJ variables
> 
> Remove substitution of *_OBJ variables (e.g. POPT_OBJ or PCRE_OBJ) from
> configure scripts as they don't seem to be set or used by anything.

ACK, they are truly unused.

> From 0050f897f4c33fc277f22831dddf40bc820ea499 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov <Nikolai.Kondrashov at redhat.com>
> Date: Fri, 25 Jul 2014 16:01:02 +0300
> Subject: [PATCH 2/6] build: Mention required libini_config version
> 
> Specify minimum required libini_config version in a message in samba.m4
> explaining the need for the library.

ACK

> From b65fc04e19a8ed212485e2e812579ddfaa261085 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov <Nikolai.Kondrashov at redhat.com>
> Date: Mon, 28 Jul 2014 12:57:32 +0300
> Subject: [PATCH 3/6] build: Distinguish libini_config version checks

ACK, nice catch

> From c221453a5acde8a75cbd51a07d9f823751454be9 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov <Nikolai.Kondrashov at redhat.com>
> Date: Fri, 25 Jul 2014 16:41:42 +0300
> Subject: [PATCH 4/6] build: Distinguish libnl version checks

ACK

> From 964e6a076397bc554efb0a86fa69e8899a23bcaf Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov <Nikolai.Kondrashov at redhat.com>
> Date: Mon, 28 Jul 2014 15:11:20 +0300
> Subject: [PATCH 5/6] build: Reverse order of libini_config checks

ACK


> From d597c5d7c6d1e312a8d1adac95f336deb0b1b135 Mon Sep 17 00:00:00 2001
> From: Nikolai Kondrashov <Nikolai.Kondrashov at redhat.com>
> Date: Mon, 28 Jul 2014 15:21:21 +0300
> Subject: [PATCH 6/6] build: Move libini_config 1.1.0 check to libini_config.m4

ACK, we just need to keep in mind that checking for libini must happen
before checking for Samba in the build system. But I guess a failed
build would tell us exactly :)

I tested the patches on Fedora-20 and RHEL-6 (latest and oldest OS
releases we support). With libini 1.1 everything went fine, with stocke
RHEL-6.5 libini the build failed during configure phase.



More information about the sssd-devel mailing list