[SSSD] [PATCH] SDAP: remove duplicated code

Jakub Hrozek jhrozek at redhat.com
Tue Jul 22 07:51:29 UTC 2014


On Tue, Jul 22, 2014 at 09:33:36AM +0200, Lukas Slebodnik wrote:
> On (22/07/14 08:48), Pavel Reichl wrote:
> >
> >On 07/21/2014 11:57 PM, Lukas Slebodnik wrote:
> >>On (21/07/14 22:13), Pavel Reichl wrote:
> >>>Hello,
> >>>
> >>>please see attached trivial patch.
> >>>
> >>>Thanks,
> >>>
> >>>Pavel Reichl
> 
> >From e1097b44fe561909a56e1c9c646fc6eb59b89764 Mon Sep 17 00:00:00 2001
> >From: Pavel Reichl <preichl at redhat.com>
> >Date: Mon, 21 Jul 2014 21:01:56 +0100
> >Subject: [PATCH] SDAP: remove duplicated code
> >
> >Body of functions sdap_x_deref_search_done(), sdap_asq_search_done(),
> >sdap_sd_search_done and sdap_get_generic_done() are the same. Remove
> >code duplication by calling sdap_get_generic_done() from
> >sdap_x_deref_search_done(), sdap_sd_search_done and from
> >sdap_asq_search_done() instead of having two more duplicate
> >implementations.
> >---
> > src/providers/ldap/sdap_async.c | 47 +++--------------------------------------
> > 1 file changed, 3 insertions(+), 44 deletions(-)
> >
> 
> ACK
> 
> LS

* master: d8dc383c438fad9b3b5ce4ad9e5c67271b22bf3a



More information about the sssd-devel mailing list