[SSSD] [PATCH] PAM: Test right variable after calling sss_atomic_read_s

Lukas Slebodnik lslebodn at redhat.com
Wed Jul 9 15:58:46 UTC 2014


ehlo,

simple patch is attached.

LS
-------------- next part --------------
>From 1be6093af657ccda43fbd80dd58d2c159977e5ef Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Wed, 9 Jul 2014 17:56:26 +0200
Subject: [PATCH] PAM: Test right variable after calling sss_atomic_read_s

---
 src/sss_client/pam_sss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sss_client/pam_sss.c b/src/sss_client/pam_sss.c
index 908ab128e706acfbface624a322f1b494e9aef01..d2502d13d3f7fe63f32f2b648fce38ca1c92f582 100644
--- a/src/sss_client/pam_sss.c
+++ b/src/sss_client/pam_sss.c
@@ -507,7 +507,7 @@ static errno_t display_pw_reset_message(pam_handle_t *pamh,
 
     errno = 0;
     total_len = sss_atomic_read_s(fd, msg_buf, stat_buf.st_size);
-    if (ret == -1) {
+    if (total_len == -1) {
         ret = errno;
         D(("read failed [%d][%s].", ret, strerror(ret)));
         goto done;
-- 
1.9.3



More information about the sssd-devel mailing list