[SSSD] [PATCH] sdap-tests: Fix off by one

Pavel Reichl preichl at redhat.com
Wed Jul 9 13:56:16 UTC 2014


On Wed, 2014-07-09 at 13:02 +0200, Lukas Slebodnik wrote:
> ehlo,
> 
> 1st patch fix valgrind warning
> 2nd patch fix linking of sdap-tests on platfrms with disabled link_all_deplibs
> 
> LS
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Hi,

I was just thinking if in the first patch we should also test the length
of strings: "strlen("1234") == key_len". But on the second thought I
don't think this is a good idea...we should simply assume that
sss_base64_decode returns correct size, right?

Anyway patches seems OK to me. 
ACK, ACK.

Regards,

Pavel Reichl




More information about the sssd-devel mailing list