[SSSD] [PATCH] LDAP: Try all attributes when saving an entry

Jakub Hrozek jhrozek at redhat.com
Tue Jul 8 18:31:22 UTC 2014


On Tue, Jul 08, 2014 at 07:41:41PM +0200, Michal Židek wrote:
> On 07/08/2014 07:31 PM, Jakub Hrozek wrote:
> >On Tue, Jul 08, 2014 at 04:23:37PM +0200, Michal Židek wrote:
> >>>[PATCH 6/7] SDAP: Remove unused function sdap_get_msg_dn
> >>>This function was unused since 2009
> >>>
> >>
> >>Could you also remove the comment.
> >>  /* =Get-DN-from-message==============
> >
> >Done.
> 
> Ack.
> 
> >
> >>
> >>>[PATCH 7/7] SDAP: Free bervals on failure in sdap_parse_entry
> >>>I wasn't able to test this patch, so review would only be with visual
> >>>inspection, I think..
> >>>
> >>
> >>I think the ldap_value_free_len call should be here as well
> >>to free the memory allocated for the one NULL pointer:
> >>  447             } else {
> >>  448                 if (!vals[0]) {
> >>  449                     DEBUG(SSSDBG_CRIT_FAILURE,
> >>  450                           "Missing value after ldap_get_values()
> >>??\n");
> >>  451                     ret = EINVAL;
> >>  452                     goto done;
> >>  453                 }
> >
> >Thanks, nice catch.
> >
> 
> Ack.

Pushed all to master:
    5ab0dedd52d248b2cf2eb028338919bc0046e2a9
    88eac3adf8424b65195e725ff724c79d38500e1d
    34de8a00f5b480ef3f46d2516e072e4acf1ebf87
    004b3589f85808bcfcb0019aa92e47d3ce4017c9
    eed2073f6f7bed7df0327b9fc0f2d410975d5332
    e592d5f157be869151983bd1b46d6f4f7a29daaf
    b1559c6498e791aa870f6e01948d1ad0f1af32e7



More information about the sssd-devel mailing list