[SSSD] [PATCH] TESTS: Do not rely on order of hash items

Jakub Hrozek jhrozek at redhat.com
Mon Jul 7 13:21:24 UTC 2014


On Mon, Jul 07, 2014 at 02:08:28PM +0200, Lukas Slebodnik wrote:
> >Thanks for the review, new patch is attached.
> 
> >From 4f067bbe180a255ff7b873050a092ab3823b9cb5 Mon Sep 17 00:00:00 2001
> >From: Jakub Hrozek <jhrozek at redhat.com>
> >Date: Fri, 4 Jul 2014 14:42:45 +0200
> >Subject: [PATCH] TESTS: Do not rely on order of hash items
> >
> >The nested group test was checking returned elements in a particular
> >order. That's not reliable because the returned values are fetched from
> >a hash iterator that doesn't guarantee the same order on different
> >systems.
> >---
> > src/tests/cmocka/test_nested_groups.c | 82 +++++++++++++++++++++--------------
> > 1 file changed, 50 insertions(+), 32 deletions(-)
> >
> >diff --git a/src/tests/cmocka/test_nested_groups.c b/src/tests/cmocka/test_nested_groups.c
> >index 463d66efbbde28934d54cc71365b32b0c7fbbee1..955d05dd426af5219b7187046920de86437da4b3 100644
> >--- a/src/tests/cmocka/test_nested_groups.c
> >+++ b/src/tests/cmocka/test_nested_groups.c
> nestedgroups-tests passed with your patch on ix86.
> 
> ACK
> 
> LS

Thanks for the review, pushed to master:
    be8e3c2eb7619ae1b94fd8941e0f18c8969b2804



More information about the sssd-devel mailing list