[SSSD] [PATCH] Exit offline mode only if server is available.

Sumit Bose sbose at redhat.com
Fri Jul 4 08:16:21 UTC 2014


On Thu, Jul 03, 2014 at 01:56:09PM +0200, Michal Židek wrote:
> Hi,
> 
> this patch solves the ticket
> https://fedorahosted.org/sssd/ticket/2355
> 
> I was able to reproduce the slowdowns that the
> reported experienced by pausing a virtual machine
> with the server. With this patch the slowdowns
> no longer appear.
> 
> I use the already implemented function check_if_online
> in the new periodic task. See patch description
> for more details.

I have one minor concern with the approach. On busy systems there is no
difference after a minute SSSD tries to go online. But if the system is
idle SSSD waited for some activity before tying to go online. With your
patch it will continue to try to go online every minute. For a system
running idle during the night this might be a lot of useless request.

I wonder if the current online-check can just be made a background task
and the backend returns immediately with the offline status? For busy
systems there would be basically no difference as well. For the running
idle over night use-case there would be a little drawback. With your
scheme if SSSD goes online during the night the first request in the
morning already it attempted online. While with my suggestion it will
still be offline. But since the first would be a lookup request in most
case and an authentication following this has a fair chance to already
to online I think it is only a minor drawback.

Please note that this is just a suggestion, your patch is fine and it is
a big improvement of the current behaviour. If you or others prefer to
keep it this way I'm fine and I'll happily would start to review the
patch.

bye,
Sumit

> 
> Patches for master and sssd-1-11 are in
> the attachment.
> 
> Thanks,
> Michal



More information about the sssd-devel mailing list