[SSSD] [PATCH] sss_sifp: pkg-config requires is a comma separated list

Jakub Hrozek jhrozek at redhat.com
Thu Jul 3 12:35:12 UTC 2014


On Wed, Jul 02, 2014 at 01:46:49PM +0200, Pavel Březina wrote:
> cmake complained about this when building openlmi

What was the error you were seeing?

As a note, I was reading the pkg-config docs again:
    http://people.freedesktop.org/~dbn/pkg-config-guide.html
and I think it's correct we use Requires and not Requires.private since
we do expose some libdbus types in our public header.

I'm inclined to ack this patch, but I'd like to see the particular error
first.

> From 3b945c3da5b3717752451cac7868b285f158eabd Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina at redhat.com>
> Date: Wed, 2 Jul 2014 13:45:53 +0200
> Subject: [PATCH] sss_sifp: pkg-config requires is a comma separated list
> 
> ---
>  src/lib/sifp/sss_simpleifp.pc.in | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/lib/sifp/sss_simpleifp.pc.in b/src/lib/sifp/sss_simpleifp.pc.in
> index a8b625608b0e8451b8fa44e1a927d51a3e11cef1..e57ed8db4174db433d0aad56cbd8179c140e0b17 100644
> --- a/src/lib/sifp/sss_simpleifp.pc.in
> +++ b/src/lib/sifp/sss_simpleifp.pc.in
> @@ -4,8 +4,7 @@ includedir=@includedir@
>  Name: sss_simpleifp
>  Description: A library that simplifies work with the InfoPipe responder
>  Version: @VERSION@
> -Requires: dbus-1
> -Requires: dhash
> +Requires: dbus-1, dhash
>  Libs: -L at libdir@ -lsss_simpleifp
>  Cflags: -I${includedir}
>  URL: http://fedorahosted.org/sssd/
> -- 
> 1.7.11.7
> 

> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel




More information about the sssd-devel mailing list