[SSSD] BUILD: ad_gpo_tests should be built only with samba

Jakub Hrozek jhrozek at redhat.com
Tue Jul 1 11:33:01 UTC 2014


On Tue, Jul 01, 2014 at 12:23:45PM +0200, Lukas Slebodnik wrote:
> ehlo,
> 
> ad_gpo_test is linked with library NDR_NBT, which is part of samba4.
> Simple patch is attached.

I didn't test a system without samba-libs, but I tested that when sssd
was configured --without-samba, the GPO tests were not built at all. I
think that still constitutes an ACK.

> 
> LS
> 
> BTW I saw in Noam's nfs patches he is using $(NULL) after the end of lists in
> Makefile.am. I saw it also in other projects. Do we want to use this patter as
> well?

I liked it as well, the additions at the end of the list can then be
truly one-liners. 



More information about the sssd-devel mailing list