[SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

Michal Židek mzidek at redhat.com
Fri Jan 31 18:51:17 UTC 2014


On 01/31/2014 07:45 PM, Lukas Slebodnik wrote:
> Almost good, except few warnings (in my case errors)
> src/responder/nss/nsssrv_cmd.c:3578:52: error: incompatible pointer types passing 'int *' to
>        parameter of type 'size_t *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]
>          SAFEALIGN_COPY_UINT32(body + bindex, &gid, &bindex);
>                                                     ^~~~~~~
> src/util/util_safealign.h:79:51: note: expanded from macro 'SAFEALIGN_COPY_UINT32'
>      safealign_memcpy(dest, src, sizeof(uint32_t), pctr)
>                                                    ^
> src/util/util_safealign.h:49:65: note: passing argument to parameter 'counter' here
> safealign_memcpy(void *dest, const void *src, size_t n, size_t *counter)
>                                                                  ^
> src/responder/nss/nsssrv_cmd.c:3588:65: error: incompatible pointer types passing 'int *' to
>        parameter of type 'size_t *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]
>          SAFEALIGN_COPY_UINT32(body + bindex, &orig_primary_gid, &bindex);
>                                                                  ^~~~~~~
> src/util/util_safealign.h:79:51: note: expanded from macro 'SAFEALIGN_COPY_UINT32'
>      safealign_memcpy(dest, src, sizeof(uint32_t), pctr)
>                                                    ^
> src/util/util_safealign.h:49:65: note: passing argument to parameter 'counter' here
> safealign_memcpy(void *dest, const void *src, size_t n, size_t *counter)
>                                                                  ^
>    CC       src/responder/nss/nsssrv_services.o
>
> LS
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>

New patch attached.

Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-responder-Use-SAFEALIGN-macros-where-appropriate.patch
Type: text/x-patch
Size: 14284 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140131/c612bef1/attachment.bin>


More information about the sssd-devel mailing list