[SSSD] [PATCH] Connect to GC during enumeration

Jakub Hrozek jhrozek at redhat.com
Wed Jan 29 13:06:14 UTC 2014


On Wed, Jan 29, 2014 at 01:32:45PM +0100, Sumit Bose wrote:
> On Tue, Jan 28, 2014 at 10:44:30PM +0100, Jakub Hrozek wrote:
> > I think I should bring up one piece of the last patch:
> > 
> > > +        /* Get the list of original DN attributes the group had in AD */
> > > +        group_odn_list = sss_ldb_el_to_string_list(tmp_ctx, om);
> > > +        if (group_odn_list == NULL) {
> > > +            ret = EFAULT;
> > > +            goto done;
> > > +        }
> > > +
> > > +        /* Compare the two lists */
> > > +        ret = diff_string_lists(tmp_ctx, discard_const(group_odn_list),
> > > +                                sysdb_odn_list, &group_only, NULL, NULL);
> > 
> > I think that using discard_const is usually frowned upon, but here I
> > think the diff_string_list prototype should be changed to accept a "const
> > char **" for the two input lists (they are strictly read-only). And I
> > would prefer to do so in a separate patch.
> 
> I agree, discard_const() should only be used for external libraries. For
> our own stuff we should try to avoid it.
> 
> bye,
> Sumit

https://fedorahosted.org/sssd/ticket/2214



More information about the sssd-devel mailing list