[SSSD] [PATCH v1 0/5] NFSv4 rpc.idmapd plugin

Simo Sorce simo at redhat.com
Sun Jan 26 19:36:20 UTC 2014


On Thu, 2014-01-16 at 11:02 +0200, Noam Meltzer wrote:
> Following the design document:
> https://fedorahosted.org/sssd/wiki/DesignDocs/rpc.idmapd%20plugin
> 
> You can find in the following 5 patches my implementation.

Hi Noam,
it is a good start, as you can see I've sent comments on the various
patches. I think we are close, but there are quite some fixes to make.

I do not have any additional comment on the whole patchset at the moment
and I agree with Lukas' comment on patch 3.

Btw I see that you had to include an internal file from libfsidmapd, but
I've seen no request on the linux-nfs mailing list to ask to make it
public.
I think we should have a conversation with them because this code could
be also contributed directly to linux-nfs instead of sssd as it is now.

Either way we should discuss with the nfs-utils maintainers whether they
want to host the code by themselves or whether they can make libnfsidmap
plugin interface public. I do not like very much to go forward
indefinitely including a private non-versioned interface from another
library in our code, as it would break badly should linux-nfs make
changes, which they can, because, so far, the interface is marked
'internal' so they are not giving any guarantee of ABI compatibility
going forward.

Do you want to start this discussion yourself on the list ?

Thanks,
Simo.


-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list