[SSSD] [PATCH] LDAP: Don't abort request if no id mapping domain matches
Jakub Hrozek
jhrozek at redhat.com
Fri Jan 24 12:57:23 UTC 2014
On Fri, Jan 24, 2014 at 01:27:51PM +0100, Sumit Bose wrote:
> On Fri, Jan 24, 2014 at 01:21:36PM +0100, Jakub Hrozek wrote:
> > On Fri, Jan 24, 2014 at 12:00:13PM +0100, Sumit Bose wrote:
> > > ACK.
> > >
> > > I wonder if you want to fix a copy-and-paste error in the following
> > > comment before push the patch?
> > >
> > > > @@ -497,7 +513,19 @@ struct tevent_req *groups_get_send(TALLOC_CTX *memctx,
> > > > /* Convert the UID to its objectSID */
> > > ^
> > > > err = sss_idmap_unix_to_sid(ctx->opts->idmap_ctx->map,
> > > > gid, &sid);
> > >
> >
> > Sure, attached is a patch I'd like to push.
>
> ACK
>
> bye,
> Sumit
Pushed to master verbatim and also pushed to sssd-1-11 with the following
modification (in 1.11, the sysdb API still requires the sysdb_ctx as well):
index ddfe14c..e36c1f6 100644
--- a/src/providers/ldap/ldap_id.c
+++ b/src/providers/ldap/ldap_id.c
@@ -134,7 +134,8 @@ struct tevent_req *users_get_send(TALLOC_CTX *memctx,
("[%s] did not match any configured ID mapping domain\n",
name));
- ret = sysdb_delete_user(state->domain, NULL, uid);
+ ret = sysdb_delete_user(state->sysdb,
+ state->domain, NULL, uid);
if (ret == ENOENT) {
/* Ignore errors to remove users that were not cached previously */
ret = EOK;
@@ -520,7 +521,8 @@ struct tevent_req *groups_get_send(TALLOC_CTX *memctx,
("[%s] did not match any configured ID mapping domain\n",
name));
- ret = sysdb_delete_group(state->domain, NULL, gid);
+ ret = sysdb_delete_group(state->sysdb,
+ state->domain, NULL, gid);
if (ret == ENOENT) {
/* Ignore errors to remove users that were not cached previously */
ret = EOK;
More information about the sssd-devel
mailing list