[SSSD] [PATCH] LDAP: Fix error check

Jakub Hrozek jhrozek at redhat.com
Fri Jan 17 10:28:23 UTC 2014


See the attached patch, sound like result of bad refactoring..
-------------- next part --------------
>From aac59d3dbbb0cd632976cfb8979b50049b67b03a Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 17 Jan 2014 10:49:27 +0100
Subject: [PATCH] LDAP: Fix error check

https://fedorahosted.org/sssd/ticket/2199
---
 src/providers/ldap/ldap_common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/providers/ldap/ldap_common.c b/src/providers/ldap/ldap_common.c
index 482271b8c22095116c7090e3ec70ed2a3c763b34..f1a2ed97e211757ebc21906482f7f18d4012b913 100644
--- a/src/providers/ldap/ldap_common.c
+++ b/src/providers/ldap/ldap_common.c
@@ -843,8 +843,8 @@ errno_t common_parse_search_base(TALLOC_CTX *mem_ctx,
         ret = sdap_create_search_base(search_bases, unparsed_base,
                                       LDAP_SCOPE_SUBTREE, old_filter,
                                       &search_bases[0]);
-        if (!search_bases[0]) {
-            ret = ENOMEM;
+        if (ret != EOK) {
+            DEBUG(SSSDBG_OP_FAILURE, ("Cannot create new sdap search base\n"));
             goto done;
         }
 
-- 
1.8.4.2



More information about the sssd-devel mailing list