[SSSD] [PATCH] AD: Return right error code from netlogon_get_flat_name

Lukas Slebodnik lslebodn at redhat.com
Thu Jan 16 16:02:48 UTC 2014


ehlo,

EOK was returned in done section of netlogon_get_flat_name,
even if error code was set in variable ret.

This patch fixes also warnings from scan-build.

oneliner attached

LS
-------------- next part --------------
>From 03f8de6fb2f995e1d1d67ac79d266d5810c9f1b2 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Thu, 16 Jan 2014 16:42:50 +0100
Subject: [PATCH] AD: Return right error code from netlogon_get_flat_name

EOK was returned in done section of netlogon_get_flat_name,
even if error code was set in variable ret.

This patch fixes also warnings from scan-build.
---
 src/providers/ad/ad_domain_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/providers/ad/ad_domain_info.c b/src/providers/ad/ad_domain_info.c
index e8987a482a6de373c037dd758b2e464f4fcc3686..e8f90cc7860e109c70472296bf8e00627e9d5b42 100644
--- a/src/providers/ad/ad_domain_info.c
+++ b/src/providers/ad/ad_domain_info.c
@@ -132,7 +132,7 @@ netlogon_get_domain_info(TALLOC_CTX *mem_ctx,
     ret = EOK;
 done:
     talloc_free(ndr_pull);
-    return EOK;
+    return ret;
 }
 
 struct ad_master_domain_state {
-- 
1.8.4.2



More information about the sssd-devel mailing list