[SSSD] [PATCH][ding_libs] INI: Include missing header files

Dmitri Pal dpal at redhat.com
Mon Jan 13 14:07:47 UTC 2014


On 01/13/2014 05:49 AM, Lukas Slebodnik wrote:
> ehlo,
>
> Function ini_config_serialize was declared in the header file ini_configobj.h,
> but this header file was not included in implementation module ini_serialize.c

This is fine though I do not see a big reason to do this.

>
> Functions print_config_parsing_errors, print_file_parsing_errors were declared
> in the header file ini_config.h, but this header file was not included
> in  implementation module ini_print.c

ini_config.h is the old interface
ini_configobj.h is the new interface

These headers should not be included into one module.
They are mutually exclusive.

Functions should probably be included into ini_configobj.h but I have
not included them because they are already declared in the old interface.
So may be we should move them from old to new rather than declare them
twice?

>
> Simple patch is attached.
>
> LS
>
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel


-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager for IdM portfolio
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140113/9f3c2783/attachment.html>


More information about the sssd-devel mailing list