[SSSD] [PATCH][ding_libs] Collection: Fix typo in function declarations

Lukas Slebodnik lslebodn at redhat.com
Mon Jan 13 10:45:17 UTC 2014


ehlo,

While I was working on symbol maps for ding_libs, I found out two declarations
of function were misspelled in the public header file. It looks like nobody
used this function, because symbols in library are correct

[root at unused-4-233 ~]# objdump -T /usr/lib64/libcollection.so | grep col_insert_unsi
0000000000006d50 g    DF .text  000000000000003b  Base col_insert_unsigned_property_with_ref
0000000000006af0 g    DF .text  000000000000003a  Base col_insert_unsigned_property

Problem is fixed with simple replacement s/ng/gn/

I can see a problem. I am not sure if we should bump SONAME,
because ABI of library is not changed, but API is technically
changed in imcompatible way (two functions were removed and two functions were
added). It looks like nobody used this functions, because it is impossible to
link program with wrong declaration.

LS
-------------- next part --------------
>From c38495f219281e6a1d6c46f3db607fc456f6e3c0 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Fri, 10 Jan 2014 21:18:45 +0100
Subject: [PATCH] Collection: Fix typo in function declarations

There were two declaration of functions, which didn't have a
definition.
    col_insert_unsinged_property
    col_insert_unsinged_property_with_ref
It was a typo and it is fixed with replacement s/ng/gn/
---
 collection/collection.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/collection/collection.h b/collection/collection.h
index 2ec81bdb68ae4b67e2bbca1a0e0fbd0202fefb1e..48b28cc7ebfe0c17cedbddb55a40806bf579b886 100644
--- a/collection/collection.h
+++ b/collection/collection.h
@@ -1772,7 +1772,7 @@ int col_insert_int_property(struct collection_item *ci,
                             int32_t number);
 
 /** @brief Insert an unsigned property. */
-int col_insert_unsinged_property(struct collection_item *ci,
+int col_insert_unsigned_property(struct collection_item *ci,
                                  const char *subcollection,
                                  int disposition,
                                  const char *refprop,
@@ -1857,7 +1857,7 @@ int col_insert_int_property_with_ref(struct collection_item *ci,
                                      struct collection_item **ret_ref);
 
 /** @brief Insert an unsigned property and get back a reference. */
-int col_insert_unsinged_property_with_ref(struct collection_item *ci,
+int col_insert_unsigned_property_with_ref(struct collection_item *ci,
                                           const char *subcollection,
                                           int disposition,
                                           const char *refprop,
-- 
1.8.4.2



More information about the sssd-devel mailing list