[SSSD] [PATCH] Warnings and -Werror from ./configure

Stef Walter stefw at redhat.com
Fri Jan 10 12:38:33 UTC 2014


On 10.01.2014 10:26, Jakub Hrozek wrote:
> On Thu, Jan 09, 2014 at 09:26:40PM +0100, Stef Walter wrote:
>> diff --git a/configure.ac b/configure.ac
>> index f89de6e..9156dfa 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -325,7 +325,7 @@ SSS_WARNINGS='
>>  for option in $SSS_WARNINGS; do
>>      SAVE_CFLAGS="$CFLAGS"
>>      CFLAGS="$CFLAGS $option"
>> -    AC_MSG_CHECKING([whether compiler understands $option])
>> +    AC_MSG_CHECKING([compiler option $option])
> 
> Was this hunk intended to be part of patch #1 ?

Moved to first patch.

> I think there should be a default for "enable_strict". Othwerwise the
> configure output looks a bit odd when neither --enable-strict nor
> --disable-strict is selected:

Right ... removed the tristate, now it's just either on or off,
defaulting to off (at least for now).

In other projects I've used it as a tristate where --enable-strict turns
on strictness, and --disable-strict makes things more liberal than
default. But no need to get into that here.

Cheers,

Stef
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-configure-Enable-usual-SSSD_WARNINGS-automatically.patch
Type: text/x-patch
Size: 3125 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140110/84ac83c2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-configure-Add-strict-compilation-mode-with-enable-st.patch
Type: text/x-patch
Size: 1056 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140110/84ac83c2/attachment-0001.bin>


More information about the sssd-devel mailing list