[SSSD] [PATCH] LDAP: Add a new error code for malformed access control filter

Jakub Hrozek jhrozek at redhat.com
Thu Jan 9 14:58:16 UTC 2014


On Thu, Jan 09, 2014 at 08:45:08AM -0500, Simo Sorce wrote:
> On Thu, 2014-01-09 at 10:50 +0100, Jakub Hrozek wrote:
> > I was actually thinking about mass-replacing strerror for sss_strerror
> > in master..since sss_strerror is backwards-compatible, there should be
> > no
> > issues even if strerror was used to print error message from a system
> > call like write(2) where only errno-ranged error code was present.
> > 
> > Given that we already have one large automated patch (the DEBUG
> > levels) coming up and the strerror() calls are largely in the same
> > area
> > the churn wouldn't be too high..
> > 
> It would be simpler to add this in header files:
> #undef strerror
> #define strerror sss_strerror
> 
> Simo.

Right, since sss_strerror is backwards compatible, this would work.

Should we convert the sss_strerror back to strerror, then, to not
confuse developers with two similar calls?



More information about the sssd-devel mailing list