[SSSD] [PATCH] Remove useless assignment to function parameter

Lukas Slebodnik lslebodn at redhat.com
Wed Feb 26 21:03:32 UTC 2014


On (26/02/14 14:36), Simo Sorce wrote:
>On Wed, 2014-02-26 at 20:23 +0100, Jakub Hrozek wrote:
>> On Wed, Feb 26, 2014 at 08:18:49PM +0100, Lukas Slebodnik wrote:
>> > Only function hbac_free_info can be changed; but it will be change of API
>> > in ipa/ipa_hbac.h. In this case, I would prefer to file a ticket
>> > and to do similar change also in libsss_idmap library
>> >     {sss_idmap_free, sss_idmap_free_sid, sss_idmap_free_dom_sid,
>> >     sss_idmap_free_smb_sid, sss_idmap_free_bin_sid}
>> 
>> Yes please, these are public APIs, let's not rush the change.
>
>For public apis we can only create a new api starting using it and mark
>old ones as deprecated ... but it is doable if we really want to.
>
If we (YOU :-) want to, please file a ticket.

BTW patch only remove dead code, it is not a bocker.

LS



More information about the sssd-devel mailing list