[SSSD] [PATCH] config API: prepend source dir search path for tests

Sumit Bose sbose at redhat.com
Wed Feb 26 10:45:58 UTC 2014


Hi,

I came across this while testing some changes to the config API.

Additionally I realized that the config API opens every file in
schemaplugindir (.../sssd.api.d) including hidden ones starting with a
'.'. This might lead to test failures if backup copies or swap file of
running editors are read. Since this is primarily an issue on developers
systems I wonder if this should be fixed or not?

bye,
Sumit
-------------- next part --------------
From 9442c695c13b8da547e5d561303847357873d9db Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Wed, 26 Feb 2014 11:35:24 +0100
Subject: [PATCH] config API: prepend source dir search path for tests

Instead of appending the search patch in the source directory should be
prepended. Otherwise the test might find files installed in the default
paths of the system first.
---
 src/config/SSSDConfigTest.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/config/SSSDConfigTest.py b/src/config/SSSDConfigTest.py
index 7cfbddc..a0c7d31 100755
--- a/src/config/SSSDConfigTest.py
+++ b/src/config/SSSDConfigTest.py
@@ -12,7 +12,7 @@ import sys
 
 srcdir = os.getenv('srcdir')
 if srcdir:
-    sys.path.append("./src/config")
+    sys.path.insert(0, "./src/config")
     srcdir = srcdir + "/src/config"
 else:
     srcdir = "."
-- 
1.8.3.1



More information about the sssd-devel mailing list