[SSSD] [PATCH] UTIL: Sanitize spaces.

Jakub Hrozek jhrozek at redhat.com
Tue Feb 25 13:23:25 UTC 2014


On Mon, Feb 24, 2014 at 11:48:23AM +0100, Lukas Slebodnik wrote:
> ehlo,
> 
> resendig patch from trac to review.
> 
> Original patches submitted by: mpesari(Thanks!!)
> 
> It can cause problems if user will hit spaces before entering username.
> (e.g in gdm). Spaces are ignored by LDAP; it's better to escape them.
> 
> Resolves:
> https://fedorahosted.org/sssd/ticket/1955

I tested that the issue the ticket describes is resolved and normal
functionality (including lookups of groups with spaces, tested with
"domain users") still works.

So ACK to the patch

> 
> Do we want to escape '\t' (horizontal tab) as well?
> 
> LS

We could, for completeness' sake, but I don't think that users would run
into the issue described originally. The spacebar is much easier target
than tab key :-)



More information about the sssd-devel mailing list