[SSSD] [PATCH] LDAP: Setup periodic task only once.

Jakub Hrozek jhrozek at redhat.com
Mon Feb 24 19:34:35 UTC 2014


On Sat, Feb 22, 2014 at 12:18:01AM +0100, Lukas Slebodnik wrote:
> ehlo,
> 
> If id provider is {ipa, ad} periodic task will be stared in sssm_{ipa,ad}_init
> If you enable enumeration and use different providers for id and sudo(autofs)
> then another periodic task will be scheduled.
> This can cause weird behaviour (e.g. missing members of group)
> 
> I provided test package to reporter of bug #2153 with attached patch
> (actually it was patch for 1.9 branch). I was not able to reproduce problem
> with missing groups. Thus I was wainting for response from customer.
> But it will be better to do a (pre-)review of patch.
> 
> I am also attaching part of log file. You can notice Two enumerations are
> started. There is difference only few milliseconds.
> 
> LS

I admit I would have preferred an idempotent solution that would just
result in a noop if called twice (maybe checking if either cleanup or enum
is loaded), but after some time thinking about the solution I don't think
it would be so easy.

Could you just add a comment to ldap_id_init_internal() explaining what
the main_init does and another comment to sssm_ldap_id_init() reminding
the developer that changes should go directly to ldap_id_init_internal()
?



More information about the sssd-devel mailing list