[SSSD] [PATCH] DBus: Refactor how requests are handled

Stef Walter stefw at redhat.com
Mon Feb 24 10:42:32 UTC 2014


Here's the next patchset for refactoring the DBus support in sssd.

This patch set reorganizes how handlers handle requests. At center stage
is 'struct sbus_request' which is a talloc context valid for the
duration of the DBus requests.

There are also various sbus_request_xxx_finish() methods which reply to
the caller and cleanup the request.

The next set of patches (after this one) have the support for
automatically invoking type-safe handlers and build off of this
patchset. That said, even on this own, these changes result in lots of
cleanup and some code savings.

Patch 0001 fixes portability bugs.

I've added some test cases for the sbus code that has changed.

However since there are no automatic tests for much of the monitor and
data provider methods, I would recommend lots of smoke testing for these
patches.

If you prefer to access this as a branch, see:

https://github.com/stefwalter/sssd/tree/dbus-request

To see the later work that builds off of this:

https://github.com/stefwalter/sssd/tree/dbus-invoke

Cheers,

Stef
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-providers-Fix-types-passed-to-dbus-varargs-functions.patch
Type: text/x-patch
Size: 7086 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140224/7dc480ee/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-sbus-Add-struct-sbus_request-to-represent-a-DBus-inv.patch
Type: text/x-patch
Size: 74532 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140224/7dc480ee/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-sbus-Refactor-how-we-export-DBus-interfaces.patch
Type: text/x-patch
Size: 56542 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140224/7dc480ee/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-sbus-Make-sbus_new_server-work-for-non-priveleged-pr.patch
Type: text/x-patch
Size: 1075 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140224/7dc480ee/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-sbus_tests-Add-some-testing-of-dispatch-and-handler-.patch
Type: text/x-patch
Size: 15610 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140224/7dc480ee/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-sbus-Add-the-sbus_request_parse_or_finish-method.patch
Type: text/x-patch
Size: 20983 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140224/7dc480ee/attachment-0005.bin>


More information about the sssd-devel mailing list