[SSSD] [PATCH] test_dyndns: Test right variable after allocation

Lukas Slebodnik lslebodn at redhat.com
Fri Feb 14 09:31:30 UTC 2014


ehlo,

I found it by chance.

Simple patch is attached.

LS
-------------- next part --------------
>From 306cf790ffafca0f7a8ac5971c0b13bc5a3fcfa7 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Fri, 14 Feb 2014 10:27:23 +0100
Subject: [PATCH] test_dyndns: Test right variable after allocation.

---
 src/tests/cmocka/test_dyndns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tests/cmocka/test_dyndns.c b/src/tests/cmocka/test_dyndns.c
index 9d0e196c8599c685631ec2d381d86c0a3ccfa8b9..316ba5dee34afa208aa8718c0c1e36e19f1c318f 100644
--- a/src/tests/cmocka/test_dyndns.c
+++ b/src/tests/cmocka/test_dyndns.c
@@ -118,7 +118,7 @@ int __wrap_getifaddrs(struct ifaddrs **_ifap)
         ifap_prev = ifap;
 
         ifap->ifa_name = talloc_strdup(ifap, name);
-        if (ifap == NULL) {
+        if (ifap->ifa_name == NULL) {
             errno = ENOMEM;
             goto fail;
         }
-- 
1.8.5.3



More information about the sssd-devel mailing list