[SSSD] [PATCH] bashrc_sssd fixes

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Thu Feb 13 08:31:59 UTC 2014


On 02/12/2014 08:57 PM, Michal Židek wrote:
> On 02/07/2014 02:12 PM, Nikolai Kondrashov wrote:
>>   # them. This builds with optimizations turned off and GDB debugging symbols.
>>   chmake()
>>   {
>> -    make V=0 CFLAGS+="-ggdb3 -O0 $SSS_WARNINGS ${SSS_WERROR-}" \
>> +    make V=0 CFLAGS="-ggdb3 -O0 $SSS_WARNINGS ${SSS_WERROR-}" \
>>            -j$PROCESSORS check "$@"
>>   }
>>
>> @@ -90,11 +90,12 @@ remake()
>>   }
>>
>>   # Clean the build directory and rebuild all objects, hiding most of the build
>> -# output except for warnings and errors. This builds with standard CFLAGS.
>> +# output except for warnings and errors. This builds with default
>> +# optimization and without debugging symbols.
>>   warn()
>>   {
>>       make clean >/dev/null \
>> -        && make CFLAGS+="$SSS_WARNINGS" -j$PROCESSORS tests > /dev/null "$@"
>> +        && make CFLAGS="$SSS_WARNINGS" -j$PROCESSORS tests > /dev/null "$@"
>>   }
>>
>
> Maybe I misunderstood what Stephen said, but I do not think he wanted to
> replace the "+=" with "=". If I understood it correctly, his only concern
> was the bad comment, that said we are using default CFLAGS, but in fact we
> are not, because we add something with the "+=" (and if someone exported
> some nondefault CFLAGS, it actually has nothing to with default CFLAGS, or
> the word "default" may be misleading).
>
> I do not think it is correct to remove the "+", because it changes the
> behaviour for some people.

Yes, I didn't think about environment variables, will fix. Thank you, Michal.

Sincerely,
Nick



More information about the sssd-devel mailing list