[SSSD] DEBUG macro refactoring v6

Lukas Slebodnik lslebodn at redhat.com
Wed Feb 12 22:21:45 UTC 2014


On (12/02/14 22:40), Jakub Hrozek wrote:
>On Wed, Feb 12, 2014 at 05:04:39PM +0100, Jakub Hrozek wrote:
>> On Wed, Feb 12, 2014 at 10:38:45AM -0500, Stephen Gallagher wrote:
>> > -----BEGIN PGP SIGNED MESSAGE-----
>> > Hash: SHA1
>> > 
>> > On 02/12/2014 10:12 AM, Jakub Hrozek wrote:
>> > > On Wed, Feb 12, 2014 at 10:10:10AM -0500, Stephen Gallagher wrote:
>> > >> Self-nack.
>> > >> 
>> > >> Sorry, I just realized I mistakenly rebased the v3 patches, not
>> > >> the v4 ones. I'll get a new set of these out in a short while.
>> > > 
>> > > Thanks, the ldb messages were always displayed with this version
>> > > :)
>> > > 
>> > 
>> > Yup, that's how I realized I made the mistake.
>> > 
>> > > I'll refrain from pushing any more patches to master in the
>> > > meantime.
>> > 
>> > Thanks.
>> > 
>> > 
>> > New patches attached. These should be the correct ones now. These
>> > necessitated a rebase of my journald patches as well, so I'll send
>> > those too.
>> 
>> all debug levels seem to be working fine
>> 
>> ACK
>> 
>> I'll just run them through coverity to be sure.
>
>Coverity found some errors which seem completely unrelated - code that
>was prefixed by a comment saying "we should never get here" was marked as
>dead code.
2 new errors were found.
2 errors were fixed.

Result: 0 :-)

>I suspect that this is due to a new scanner version and  dead
>code is a soft error anyway, so I'm going to push the patches.
>
>Thanks everyone for the work put into the patchset and the patience!

LS



More information about the sssd-devel mailing list