[SSSD] [PATCH] use proper Kerberos CFLAGS

Lukas Slebodnik lslebodn at redhat.com
Fri Feb 7 16:44:32 UTC 2014


On (07/02/14 17:13), Alexey Shabalin wrote:
>2014-02-06 Lukas Slebodnik <lslebodn at redhat.com>:
>
>> On (06/02/14 16:23), Jakub Hrozek wrote:
>> >On Thu, Feb 06, 2014 at 04:17:50PM +0100, Lukas Slebodnik wrote:
>> >> I was not able reproduce compilation failures with custom build of MIT
>> Kerberos
>> >> installed in /usr/local/. It could not be influenced by libraries
>> installed
>> >> from rpm, because I remove packages krb5-workstation, krb5-devel,
>> krb5-libs
>> >> (rpm -e --nodeps). I also tried build sssd on ubuntu (with custom build
>> of MIT
>> >> Kerberos) and there was not any problem.
>> >>
>> >> I had to install MIT Kerberos into different directory
>> >> (prefix /usr/local/extra/), but your patch did not solve all problem.
>> >>
>> >> user at user-virtual-machine:/tmp/sssd$ krb5-config --libs
>> >>    -L/usr/local/extra/lib -Wl,--enable-new-dtags -Wl,-rpath
>> >>    -Wl,/usr/local/extra/lib -lkrb5 -lk5crypto -lcom_err
>> >> user at user-virtual-machine:/tmp/sssd$ krb5-config --cflags
>> >>    -I/usr/local/extra/include
>> >> user at user-virtual-machine:/tmp/sssd$ krb5-config --version
>> >>    Kerberos 5 release 1.12.1
>> >>
>> >>   CCLD   sssd_pac_plugin.la
>> >> /usr/bin/ld: cannot find -lkrb5
>> >> collect2: error: ld returned 1 exit status
>> >> make[2]: *** [sssd_pac_plugin.la] Error 1
>> >> make[2]: Leaving directory `/tmp/sssd'
>> >> make[1]: *** [all-recursive] Error 1
>> >> make[1]: Leaving directory `/tmp/sssd'
>> >> make: *** [all] Error 2
>> >>
>> >> There was hardcoded "-lkrb5" in Makefile, so I changed it into
>> $(KRB5_LIBS)
>>
>
>Yes, true.
>Sorry, i did not even look such elementary mistakes.
>
>
>> >>
>> >> But there was another problem.
>> >>
>> >>   CC     src/providers/ldap/ldap_id.lo
>> >> In file included from ./src/providers/krb5/krb5_common.h:34:0,
>> >>                  from ./src/providers/ldap/ldap_common.h:29,
>> >>                  from src/providers/ldap/ldap_id.c:32:
>> >> ./src/util/sss_krb5.h:30:23: fatal error: krb5/krb5.h: No such file or
>> directory
>> >> compilation terminated.
>> >>
>> >>
>>
>
>Please, try new patch.
>
>
>
>> >> So I gave up to fix all problems.
>> >> Do you want to fix them?
>> >>
>> >> Thank you very much for your effort in improving sssd build system.
>> >>
>> >> LS
>> >
>> >I don't think we need to reproduce the failures per se. If the patch
>> >helps their distribution while not breaking ours, that's good enough for
>> >me.
>>
>> In my opinion, Alexander-s patch does not solve all problems.
>> Adding Alexey Shabalin to CC.
>>
>> Could you confirm attached patch solves problem on ALT Linux?
>>
>> LS
>>
>
>
>
>-- 
>Alexey Shabalin

>From bc016f8d928e4ce08a09783a0a0a7705ccdc92da Mon Sep 17 00:00:00 2001
>From: Alexey Shabalin <shaba at altlinux.ru>
>Date: Fri, 7 Feb 2014 17:02:03 +0400
>Subject: [PATCH] There are cases when MIT Kerberos is installed with includes
> in a subdirectory of /usr/include (or /usr/local/include).
>
>In such case we have to properly use KRB5_CFLAGS to reach them.
>
>https://fedorahosted.org/sssd/ticket/2226
>---
> Makefile.am          | 12 ++++++++++--
> src/external/krb5.m4 |  5 +++++
> 2 files changed, 15 insertions(+), 2 deletions(-)
>
>diff --git a/Makefile.am b/Makefile.am
>index 9c155d68c7f452bb02a4da154992fa2fca6af273..7e6d8f1d860b947121a67eeade0577cdd01e55a5 100644
>--- a/Makefile.am
>+++ b/Makefile.am

Did you build sssd with installed package cmocka?
Because I can see some problems in cmocka unit tests.

You can squash attached patch to yours.
Please, try to keep the 1st line in the commit message
shorter than 80 characters.

LS



More information about the sssd-devel mailing list