[SSSD] [PATCH] bashrc_sssd fixes

Lukas Slebodnik lslebodn at redhat.com
Fri Feb 7 13:31:01 UTC 2014


On (06/02/14 15:16), Stephen Gallagher wrote:
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>On 02/06/2014 02:49 PM, Nikolai Kondrashov wrote:
>> Hi everyone,
>> 
>> Attached are several fixes for bashrc_sssd script.
>> 
>> Sincerely, Nick
>> 
>> 
>
>Patch 0001: Ack
>
>
>
>Patch 0002: Nack
>
>Minor nitpick: some lines are now longer than 79 characters.
>
>Could you correct the comment on warn() to read that it builds with
>default optimization? Since we are actually setting CFLAGS+= here, it
>really isn't using the defaults.
>
CFLAGS+=something has never worked for me.

For example:
make CFLAGS+="-Wextra" V=1

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../sssd -Wall -Iinclude -I..
-I../sssd/include -I../sssd/src/sss_client -I../sssd/src -Iinclude -I.
-I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/libnl3
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
-DLIBDIR=\"/usr/local/lib\" -DVARDIR=\"/usr/local/var\" -DSHLIBEXT=\"\"
-DSSSD_LIBEXEC_PATH=\"/usr/local/libexec/sssd\" -DSSSD_INTROSPECT_PATH=\"\"
-DSSSD_CONF_DIR=\"/usr/local/etc/sssd\"
-DSSS_NSS_MCACHE_DIR=\"/usr/local/var/lib/sss/mc\"
-DSSS_NSS_SOCKET_NAME=\"/usr/local/var/lib/sss/pipes/nss\"
-DSSS_PAM_SOCKET_NAME=\"/usr/local/var/lib/sss/pipes/pam\"
-DSSS_PAC_SOCKET_NAME=\"/usr/local/var/lib/sss/pipes/pac\"
-DSSS_PAM_PRIV_SOCKET_NAME=\"/usr/local/var/lib/sss/pipes/private/pam\"
-DSSS_SUDO_SOCKET_NAME=\"/usr/local/var/lib/sss/pipes/sudo\"
-DSSS_AUTOFS_SOCKET_NAME=\"/usr/local/var/lib/sss/pipes/autofs\"
-DSSS_SSH_SOCKET_NAME=\"/usr/local/var/lib/sss/pipes/ssh\"
-DLOCALEDIR=\"/usr/local/share/locale\" -Wall -Wshadow -Wstrict-prototypes
-Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings
-Werror-implicit-function-declaration -fno-strict-aliasing -std=gnu99 -Wextra
-MT src/sss_client/autofs/sss_autofs.lo -MD -MP -MF
src/sss_client/autofs/.deps/sss_autofs.Tpo -c
../sssd/src/sss_client/autofs/sss_autofs.c  -fPIC -DPIC -o
src/sss_client/autofs/.libs/sss_autofs.o

CFLAGS was not extened but overwritten. As a result of this, sssd was not build
with debug symbols.

LS



More information about the sssd-devel mailing list