[SSSD] [PATCH 4/7] responder: Use SAFEALIGN macros where appropriate.

Lukas Slebodnik lslebodn at redhat.com
Mon Feb 3 10:34:21 UTC 2014


On (31/01/14 19:51), Michal Židek wrote:
>On 01/31/2014 07:45 PM, Lukas Slebodnik wrote:
>>Almost good, except few warnings (in my case errors)
>>src/responder/nss/nsssrv_cmd.c:3578:52: error: incompatible pointer types passing 'int *' to
>>       parameter of type 'size_t *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]
>>         SAFEALIGN_COPY_UINT32(body + bindex, &gid, &bindex);
>>                                                    ^~~~~~~
>>src/util/util_safealign.h:79:51: note: expanded from macro 'SAFEALIGN_COPY_UINT32'
>>     safealign_memcpy(dest, src, sizeof(uint32_t), pctr)
>>                                                   ^
>>src/util/util_safealign.h:49:65: note: passing argument to parameter 'counter' here
>>safealign_memcpy(void *dest, const void *src, size_t n, size_t *counter)
>>                                                                 ^
>>src/responder/nss/nsssrv_cmd.c:3588:65: error: incompatible pointer types passing 'int *' to
>>       parameter of type 'size_t *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]
>>         SAFEALIGN_COPY_UINT32(body + bindex, &orig_primary_gid, &bindex);
>>                                                                 ^~~~~~~
>>src/util/util_safealign.h:79:51: note: expanded from macro 'SAFEALIGN_COPY_UINT32'
>>     safealign_memcpy(dest, src, sizeof(uint32_t), pctr)
>>                                                   ^
>>src/util/util_safealign.h:49:65: note: passing argument to parameter 'counter' here
>>safealign_memcpy(void *dest, const void *src, size_t n, size_t *counter)
>>                                                                 ^
>>   CC       src/responder/nss/nsssrv_services.o
>>
>>LS
>>_______________________________________________
>>sssd-devel mailing list
>>sssd-devel at lists.fedorahosted.org
>>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>>
>
>New patch attached.
>
>Michal

>From 752013562af83c338344613b7278f7cc2cae6a36 Mon Sep 17 00:00:00 2001
>From: Michal Zidek <mzidek at redhat.com>
>Date: Wed, 28 Aug 2013 12:46:58 +0200
>Subject: [PATCH] responder: Use SAFEALIGN macros where appropriate.
>
>https://fedorahosted.org/sssd/ticket/1359
>---

I tested patch and works fine.
Thank you for you effort to remove cast-align warnings.
There are few warnings in sssd build but they are unrelated to this patch.

ACK



More information about the sssd-devel mailing list